Skip to content

patch: fix estimator kwargs in signature #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2024
Merged

patch: fix estimator kwargs in signature #693

merged 4 commits into from
Aug 6, 2024

Conversation

@FBruzzesi
Copy link
Collaborator

@FBruzzesi FBruzzesi commented Jul 28, 2024

Description

Hotfix to properly cloning kwargs in estimator __init__. This is both a bug fix and a breaking change!

Fixes #692

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

FBruzzesi
FBruzzesi commented Jul 28, 2024
View reviewed changes
docs/_scripts/meta-models.py
("discrete", Pipeline([
("grab", ColumnSelector("diet")),
("encode", OneHotEncoder(categories="auto", sparse=False))
("encode", OneHotEncoder(categories="auto"))
Copy link
Collaborator Author

@FBruzzesi FBruzzesi Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwarg name changed in one of the latest versions, unrelated to PR

FBruzzesi
FBruzzesi commented Jul 28, 2024
View reviewed changes
docs/_static/meta-models/decay-model.png
Copy link
Collaborator Author

@FBruzzesi FBruzzesi Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koaning there you go! 😇🙌🏼

@FBruzzesi FBruzzesi requested a review from koaning August 4, 2024 21:16
koaning
koaning approved these changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It always surprises me how small edits can suddenly demand a change in so many files 😅

@koaning koaning merged commit f25377d into main Aug 6, 2024
@FBruzzesi FBruzzesi deleted the patch/clone-kwargs branch August 6, 2024 20:53
@FBruzzesi
Copy link
Collaborator Author

FBruzzesi commented Aug 6, 2024

It always surprises me how small edits can suddenly demand a change in so many files 😅

Wait until a tiny tiny change to support pyarrow via narwhals will become a rework 🙈

As soon as we make a new Narwhals release I should be able to open the PR, yet I would like to wait for pyarrow shift PR to be merged so that also add_lags should be able to operate with pyarrow tables

@FBruzzesi FBruzzesi mentioned this pull request Aug 21, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koaning koaning koaning approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] regression in grouped estimator

3 participants

@FBruzzesi @koaning